Edited Songs show the first theme even if you change it to one of the others by editing

Version of OpenLP
2_4_5
Operating system
Windows 10
1. I edited a song to change some text and in the process the song got saved with the first theme on the list, previously it was the default (I think that mean't it was blank on the theme tab)
I went back into edit and discovered I couldn't blank or default the theme, so I chose the one that is the default, sent the song live and it still displayed with the theme accidently saved from the first edit.

I edited another song and checked the theme tab and the first theme was prefilled in the theme entry.

If I set the theme for the song in the service then it gets the theme I set,

Tested on Mac OS X and experienced the same behaviour. but also in addition if I edit the song from the service and make no changes (the template entry has been prefilled in with the first theme name)  but then when I save OpenLP throws an Error

Traceback (most recent call last):

File "openlp/core/ui/servicemanager.py", line 1501, in remote_edit

File "openlp/plugins/songs/lib/mediaitem.py", line 331, in on_remote_edit

File "openlp/plugins/songs/lib/mediaitem.py", line 212, in on_song_list_load

File "openlp/core/lib/mediamanageritem.py", line 618, in build_service_item

File "openlp/plugins/songs/lib/mediaitem.py", line 421, in generate_slide_data

File "openlp/core/lib/mediamanageritem.py", line 662, in _get_id_of_item_to_generate

RuntimeError: wrapped C/C++ object of type QListWidgetItem has been deleted



Comments

  • Thanks for reporting these issues, I did notice the first one the other day, but I haven't seen the other one. Are you able to reproduce the second one?
  • Yes I can reproduce the displaying with wrong theme issue.

    This is on Mac OS X (can't access the Windows 10 system at the moment)

    1. Clone song so I don't mess up my database even more.
    2. Edit cloned song from Song Library and make no edits, simply save.
    3. Add to Service.
    4, Go Live and the theme used is the first on the list, lets call it A.
    5. Edit song from Service and see the Theme is A, added by the no action edit.
    6. No default to choose, leave theme blank and the first theme gets filled in on save. Change the theme to B.
    7. Go Live for the song and it is still showing theme A.
    8. Add song a second time to service from the Library.
    9. The first copy of the song in the service still uses theme A but the newly added copy of the song uses B.

    Hope this helps.
  • edited February 10
    Since updating to 2.4.5 I have noticed OpenLP sets every song theme to the alphabetical first in the list ("Blue" in my case) if that song did not have a theme associated with it. I did have the themes Preference set to "Song Level." Changing the preference to "Service Level" has solved the issue for me.
    MacBook Pro Late 2011
    MacOS Sierra
    OpenLP 2.4.5

    Update: The theme set for Bible is no longer working. I use a different theme for Bible verses than songs, now both are the same with "Service Level" being selected. I have the correct bible theme selected in Preferences. 
    Also, Every song in my database now has my "Blue" theme selected. I can select a different theme and it seems to "stick" when I save my OpenLP file.
  • @simondgoodfellow I was actually asking about the error message issue. 
  • @raoul Yes I get the error message everytime

    1.clone song for testing.
    2,add to service
    3,edit from service
    4,make no changes and save
  • Hello, 
    I would like to report the same problem mentioned on the first post on win10 since the update to 2.4.5. And when I make change in a song from the service list, I must remove it and add it again to can see the modification... It was not like that in the previous version. 
    Except that, we are using openlp since some months now and we are very happy. 
  • This is a known issue and will be fixed in the next release.
Sign In or Register to comment.