2.9.4 (3.0 release candidate) - chordpro import bug

edited May 12 in Development

Hi.

Attempting to import an official SongSelect Chordpro file.

In OpenLP 2.9.4, the import feature fails to correctly read the contents of these files.

Here's a fragment from the file concerned. Observe on the last line, I'll:

Bless the [C]Lord O my [G]soul [D/F#]O my [Em]soul 
[C]Worship His [G]holy [Dsus]name  [D]
Sing like [C]never be - [Em]fore  [C]O  [D]my  [Em]soul 
I’ll [C]worship Your [D]holy [|] [C/G]name  [G]    [|] [C/G]   [G]    [|]

When imported into OpenLP, this is how it is displayed in the user interface:

You can see that the last line is corrupt, as is the 1st line of the next page.

In Linux, I isolated the relevant line from the cho file and performed a hex-dump analysis.

It's clear from the output that the apostrophe is a 3-byte, well-formed, utf-8/unicode character.

$ grep worship sample.cho | head -1 | hd
00000000 49 e2 80 99 6c 6c 20 5b 43 5d 77 6f 72 73 68 69 |I...ll [C]worshi|
00000010 70 20 59 6f 75 72 20 5b 44 5d 68 6f 6c 79 20 5b |p Your [D]holy [|
00000020 7c 5d 20 5b 43 2f 47 5d 6e 61 6d 65 20 20 5b 47 ||] [C/G]name [G|
00000030 5d 20 20 20 20 5b 7c 5d 20 5b 43 2f 47 5d 20 20 |]  [|] [C/G] |
00000040 20 5b 47 5d 20 20 20 20 5b 7c 5d 0d 0a      | [G]  [|]..|
0000004d
$ 


Assuming all SongSelect/CCLI .cho files are similar, clearly, it seems 2.9.4 cannot handle any .cho file manufactured by that site/service - which is likely to be the main source of chordpro files for most churches across the world.

Happy bug hunting!

--dave


Here's a further example - this time a Spanish language chordpro file of the same song, also from SongSelect.ccli.com

Te a - [C]labo Se - [G]ñor,  [D]oh Se - [Em]ñor
Con [C]todo mi [G]cora - [Dsus]zón  [D]
De tu [C]grande a - [Em]mor  [C]can - [D]ta - [Em]ré
Tu [C]nombre a - [D]laba - [C/G]ré  [G]

And when imported into OpenLP...


Sign In or Register to comment.